Re: [PATCH v3] Makefile: replace perl/Makefile.PL with simple make rules

From: Todd Zullinger <tmz@pobox.com>
Date: Dec 15, 2017, 15:09 UTC
Message-ID: <20171215150910.GI3693@zaya.teonanacatl.net>
In-Reply-To: <b8b4534f-1eda-ee52-faed-ec5188c2ad35@grubix.eu>

Hi Michael,

Michael J Gruber wrote:

Show 6 quoted lines

> This patch (currently in origin/next) makes a ton of tests from our test
> suite fail for me on pretty standard systems (Fedora 27, CentOS 7.4.1708).
> 
> Is there anything I'm supposed to do differently now to make our test
> suite run? If yes then a clear and short hint in the patch description
> would me more than approriate.

Interesting. I'll have to try building next. I was going to wait until the first 2.16.0 rc for a full test.

I did apply this patch on top of 2.15.1 on 12/10 and built an rpm locally for fedora (only f26 though). I didn't see any test failures, which is why I thought I'd wait for 2.16.0-rc0 to test further.

FWIW, the minor spec file changes I made (against fedora's git package master branch) are here:

    https://src.fedoraproject.org/fork/tmz/rpms/git/branch/perl-makefile

The only change in the patch since I tested it is:

+-modules += Git/Packet

in perl/Makefile.

I don't think any of these changes to the rpm spec file or the Git/Packet addition in modules look like they'd affect the test suite, but it's early here and I could be wrong.

I'll try to test a build of next soon to see if I get similar failures on Fedora/CentOS.

-- 
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
After one look at this planet any visitor from outer space would say
"I want to see the manager."
    -- William S. Burroughs