Re: [PATCH] t/helper: ignore everything but sources

From: Todd Zullinger <tmz@pobox.com>
Date: Dec 12, 2017, 21:06 UTC
Message-ID: <20171212210623.GV3693@zaya.teonanacatl.net>
In-Reply-To: <20171212205606.75581-1-sbeller@google.com>

Hi Stefan,

Stefan Beller wrote:

Show 5 quoted lines

>> If we ignore everything but resurrect *.[ch] with negative exclude
>> rules, can we do the same without moving things around?
> 
> Yes, there is also one lonely shell script in there, which also needs
> exclusion.

There aren't currently any .h files, but I suppose it doesn't hurt to include that pattern to be safer for the future.

> +*
> +!.sh
> +!.[ch]

The ! patterns are missing a '*'.  I think it should be:

* !*.[ch] !*.sh

Does it make sense to also include !.gitignore as well? It's already committed, so it's not ignored. But perhaps having it listed will save someone from getting their repo into a state where local changes to .gitignore aren't picked up (I know that's a bit of a stretch).

-- 
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
How much does it cost to entice a dope-smoking UNIX system guru to
Dayton?
    -- Brian Boyle, UNIX/WORLD's First Annual Salary Survey