[PATCH v3 6/7] diff: add tests for --relative without optional prefix value
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Dec 9, 2017, 20:40 UTC
- Message-ID
- <20171209204013.10997-6-chriscool@tuxfamily.org>
- In-Reply-To
- <20171209204013.10997-1-chriscool@tuxfamily.org>
From: Jacob Keller <jacob.keller@gmail.com>
We already have tests for --relative, but they currently only test when a prefix has been provided. This fails to test the case where --relative by itself should use the current directory as the prefix.
Teach the check_$type functions to take a directory argument to indicate which subdirectory to run the git commands in. Add a new test which uses this to test --relative without a prefix value.
Signed-off-by: Jacob Keller <jacob.keller@gmail.com> --- t/t4045-diff-relative.sh | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/t/t4045-diff-relative.sh b/t/t4045-diff-relative.sh index 3950f5034d..7d68a6e2a5 100755 --- a/t/t4045-diff-relative.sh +++ b/t/t4045-diff-relative.sh @@ -13,6 +13,7 @@ test_expect_success 'setup' ' ' check_diff() { +dir=$1; shift expect=$1; shift cat >expected <<EOF diff --git a/$expect b/$expect @@ -24,50 +25,54 @@ index 0000000..25c05ef +other content EOF test_expect_success "-p $*" " - git diff -p $* HEAD^ >actual && + git -C '$dir' diff -p $* HEAD^ >actual && test_cmp expected actual " } check_numstat() { +dir=$1; shift expect=$1; shift cat >expected <<EOF 1 0 $expect EOF test_expect_success "--numstat $*" " echo '1 0 $expect' >expected && - git diff --numstat $* HEAD^ >actual && + git -C '$dir' diff --numstat $* HEAD^ >actual && test_cmp expected actual " } check_stat() { +dir=$1; shift expect=$1; shift cat >expected <<EOF $expect | 1 + 1 file changed, 1 insertion(+) EOF test_expect_success "--stat $*" " - git diff --stat $* HEAD^ >actual && + git -C '$dir' diff --stat $* HEAD^ >actual && test_i18ncmp expected actual " } check_raw() { +dir=$1; shift expect=$1; shift cat >expected <<EOF :000000 100644 0000000000000000000000000000000000000000 25c05ef3639d2d270e7fe765a67668f098092bc5 A $expect EOF test_expect_success "--raw $*" " - git diff --no-abbrev --raw $* HEAD^ >actual && + git -C '$dir' diff --no-abbrev --raw $* HEAD^ >actual && test_cmp expected actual " } for type in diff numstat stat raw; do - check_$type file2 --relative=subdir/ - check_$type file2 --relative=subdir - check_$type dir/file2 --relative=sub + check_$type . file2 --relative=subdir/ + check_$type . file2 --relative=subdir + check_$type . dir/file2 --relative=sub + check_$type subdir file2 --relative done test_done
-- 2.15.1.361.g8b07d831d0