git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] sha1_file: use strbuf_add() instead of strbuf_addf()

From
Jeff King <peff@peff.net>
Date
Dec 4, 2017, 16:56 UTC
Message-ID
<20171204165652.GA12701@sigill.intra.peff.net>
In-Reply-To
<20171204140603.180079-1-dstolee@microsoft.com>
On Mon, Dec 04, 2017 at 09:06:03AM -0500, Derrick Stolee wrote:
> Thanks for the feedback on v1. This version fixes the cruft_cb
> bug and streamlines the strlen(). I would include an inter-diff
> but it was the same size as the patch.
Thanks, this version looks good to me. One procedural nit:
> Thanks,
> -Stolee
> 
> ---
When you put your cover letter first, you need to use "scissors" like:
-- >8 --

to separate it from the commit message. Using three-dashes means "git am" will include your cover letter as the commit message, and omit your real commit message entirely.

-Peff
Previous: Derrick StoleeNext: Derrick Stolee
Message 6 of 7 in “sha1_file: use strbuf_add() instead of strbuf_addf()”
  1. sha1_file: use strbuf_add() instead of strbuf_addf()Derrick Stolee, Dec 1, 2017
  2. Jeff KingDec 1, 2017
  3. Derrick StoleeDec 1, 2017
  4. Jeff KingDec 1, 2017
  5. sha1_file: use strbuf_add() instead of strbuf_addf()Derrick Stolee, Dec 4, 2017
  6. Jeff KingDec 4, 2017
  7. Derrick StoleeDec 4, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.