git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Make patch-id more flexible?

From
EREugeniu Rosca <erosca@de.adit-jv.com>
Date
Nov 30, 2017, 10:35 UTC
Message-ID
<20171130103539.GA19237@vmlxhi-102.adit-jv.com>
In-Reply-To
<xmqqlgiwm7x1.fsf@gitster.mtv.corp.google.com>
Hello Junio,
Show 11 quoted lines
> > file-names. Here comes my actual question. Would it be conceptually fine
> > to implement some `git patch-id` parameter, which would allow ignoring
> > the file-names (or reducing those to their `basename`) before computing
> > the patch id? Or would it break the concept of patch id (which shouldn't
> > accept variations)?
> 
> My gut feeling is that a tool like that would be fine as long as it
> is local to your organization and is not called "git patch-id"; it
> may be useful in the situation you described, but as you mention
> above, it feels that it is differnt from what a patch-id is.
>

Thank you very much for your feedback. That's exactly I was looking for. A clear statement from the maintainer. We will live then with a custom tool that acts like `git patch-id`, just strips the patches from file-names before computing the hash.

Best regards, Eugeniu.

Previous: Junio C Hamano
Message 3 of 3 in “Make patch-id more flexible?”
  1. Eugeniu RoscaNov 24, 2017
  2. Junio C HamanoNov 24, 2017
  3. Eugeniu RoscaNov 30, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.