Re: [PATCH 1/5] p5550: factor our nonsense-pack creation

From: Jeff King <peff@peff.net>
Date: Nov 23, 2017, 05:02 UTC
Message-ID: <20171123050214.GB22218@sigill>
In-Reply-To: <xmqqlgixra22.fsf@gitster.mtv.corp.google.com>

On Thu, Nov 23, 2017 at 11:41:25AM +0900, Junio C Hamano wrote:

Show 11 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > Right, I came to the same conclusion (we may even have discussed this on
> > the list, I don't remember). The current "todo" format says that only
> > the command and sha1 matter, and we'd be changing that. Maybe that's not
> > so bad if the user has to enable the feature themselves (and clearly it
> > would be incompatible with a custom format option).
> 
> If you are in the habit of always writing 4 or more lines, the
> chance that you would make a typo on the line you can correct in the
> "todo" list with such a feature is at most 25% ;-).

You'd think, but the distribution of typos doesn't seem to be uniform. :)

I think what actually happens is that I quite often do my final proofread in my MUA, where the subject is displayed apart from the rest of the message. So I tend to gloss over it, and any errors there are more likely to make it to the list.

> I think one downside is that a mere presence of such an option hints
> that we somehow encourage people to commit with a title-only message.

Yeah, though it might be handy for me I think it just opens up too many funny questions like this.

-Peff