[PATCH v4 4/4] worktree: make add <path> dwim
- From
Thomas Gummerer <t.gummerer@gmail.com>
- Date
- Nov 22, 2017, 22:30 UTC
- Message-ID
- <20171122223020.2780-5-t.gummerer@gmail.com>
- In-Reply-To
- <20171122223020.2780-1-t.gummerer@gmail.com>
Currently 'git worktree add <path>' creates a new branch named after the basename of the <path>, that matches the HEAD of whichever worktree we were on when calling "git worktree add <path>".
Make 'git worktree add <path> behave more like the dwim machinery in 'git checkout <new-branch>', i.e. check if the new branch name uniquely matches the branch name of a remote tracking branch, and if so check out that branch and set the upstream to the remote tracking branch.
This is a change of behaviour compared to the current behaviour, where we create a new branch matching HEAD. However as 'git worktree' is still an experimental feature, and it's easy to notice/correct the behaviour in case it's not what the user desired it's probably okay to break existing behaviour here.
In order to also satisfy users who want the current behaviour of creating a new branch from HEAD, add a '--no-track' flag, which disables the new behaviour, and keeps the old behaviour of creating a new branch from the head of the current worktree.
Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com> --- Documentation/git-worktree.txt | 14 ++++++++++++-- builtin/worktree.c | 7 +++++++ t/t2025-worktree-add.sh | 32 ++++++++++++++++++++++++++++++++ 3 files changed, 51 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-worktree.txt b/Documentation/git-worktree.txt index 45642d3b7f..abc8f1f50d 100644 --- a/Documentation/git-worktree.txt +++ b/Documentation/git-worktree.txt @@ -60,8 +60,18 @@ $ git worktree add --track -b <branch> <path> <remote>/<branch> ------------ + If `<branch>` is omitted and neither `-b` nor `-B` nor `--detach` used, -then, as a convenience, a new branch based at HEAD is created automatically, -as if `-b $(basename <path>)` was specified. +then, as a convenience, if there exists a tracking branch in exactly +one remote (call it `<remote>`) matching the basename of the path +(call it `<branch>`), treat it as equivalent to +------------ +$ git worktree add --track -b <branch> <path> <remote>/<branch> +------------ +If no tracking branch exists in exactly one remote, `<branch>` is +created based on HEAD, as if `-b $(basename <path>)` was specified. ++ +To disable the behaviour of trying to match the basename of <path> to +a remote, and always create a new branch from HEAD, the `--no-track` +flag can be passed to `git worktree add`. list:: diff --git a/builtin/worktree.c b/builtin/worktree.c index e9cc3f3872..cbcceb0385 100644 --- a/builtin/worktree.c +++ b/builtin/worktree.c @@ -389,6 +389,13 @@ static int add(int ac, const char **av, const char *prefix) int n; const char *s = worktree_basename(path, &n); opts.new_branch = xstrndup(s, n); + if (!opt_track || strcmp(opt_track, "--no-track")) { + struct object_id oid; + const char *remote = + unique_tracking_name(opts.new_branch, &oid); + if (remote) + branch = remote; + } } if (ac == 2 && !opts.new_branch && !opts.detach) { diff --git a/t/t2025-worktree-add.sh b/t/t2025-worktree-add.sh index ea144938a9..6fd3da4036 100755 --- a/t/t2025-worktree-add.sh +++ b/t/t2025-worktree-add.sh @@ -390,4 +390,36 @@ test_expect_success '"add" <path> <branch> dwims' ' ) ' +test_expect_success 'git worktree add --no-track does not set up tracking' ' + test_when_finished rm -rf repo_a repo_b foo && + setup_remote_repo repo_a repo_b && + ( + cd repo_b && + git worktree add --no-track ../foo + ) && + ( + cd foo && + ! test_branch_upstream foo repo_a foo && + git rev-parse repo_a/foo >expect && + git rev-parse foo >actual && + ! test_cmp expect actual + ) +' + +test_expect_success 'git worktree add sets up tracking' ' + test_when_finished rm -rf repo_a repo_b && + setup_remote_repo repo_a repo_b && + ( + cd repo_b && + git worktree add ../foo + ) && + ( + cd foo && + test_branch_upstream foo repo_a foo && + git rev-parse repo_a/foo >expect && + git rev-parse foo >actual && + test_cmp expect actual + ) +' + test_done
-- 2.15.0.345.gf926f18f3