Re: [PATCH] recursive submodules: detach HEAD from new state

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Nov 21, 2017, 22:34 UTC
Message-ID: <20171121223449.GI3429@aiede.mtv.corp.google.com>
In-Reply-To: <CAGZ79kZdoktBRBuNxVk-zehZR3Z-egEPG81KQ9WqHTEtrm+5uw@mail.gmail.com>

Stefan Beller wrote:

>> Junio C Hamano <gitster@pobox.com> writes:

Show 6 quoted lines

>>> Also, while I do agree with you that the problem exists, it is
>>> unclear why this patch is a solution and not a hack that sweeps a
>>> problem under the rug.
>>>
>>> It is unclear why this "silently detach HEAD without telling the
>>> user" is a better solution than erroring out, for example [*1*].

[...]

> So I took a step back and wrote about different proposals where
> we want to go long term. See below. This will help us
> figuring out how to approach this bug correctly.

Stefan, do you know what thread I should look at to find the current state of this patch? I've had it applied locally for a long time.

The thread I am replying to appears to be where the patch comes from but I have some memories of more recent discussion that I'm not finding.

More context: https://public-inbox.org/git/xmqqshd8i3ze.fsf@gitster.mtv.corp.google.com/ says

 * sb/submodule-recursive-checkout-detach-head (2017-07-28) 2 commits
  - Documentation/checkout: clarify submodule HEADs to be detached
  - recursive submodules: detach HEAD from new state

  "git checkout --recursive" may overwrite and rewind the history of
  the branch that happens to be checked out in submodule
  repositories, which might not be desirable.  Detach the HEAD but
  still allow the recursive checkout to succeed in such a case.

  Expecting a reroll.

Thanks, Jonathan