git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5 06/14] pack-objects: test support for blob filtering

From
JHJeff Hostetler <git@jeffhostetler.com>
Date
Nov 21, 2017, 21:15 UTC
Message-ID
<20171121211528.21891-7-git@jeffhostetler.com>
In-Reply-To
<20171121211528.21891-1-git@jeffhostetler.com>
From: Jonathan Tan <jonathantanmy@google.com>

As part of an effort to improve Git support for very large repositories in which clients typically have only a subset of all version-controlled blobs, test pack-objects support for --filter=blob:limit=<n>, packing only blobs not exceeding that size unless the blob corresponds to a file whose name starts with ".git". upload-pack will eventually be taught to use this new parameter if needed to exclude certain blobs during a fetch or clone, potentially drastically reducing network consumption when serving these very large repositories.

Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
---
 t/t5300-pack-object.sh  | 26 ++++++++++++++++++++++++++
 t/test-lib-functions.sh | 12 ++++++++++++
 2 files changed, 38 insertions(+)
diff --git a/t/t5300-pack-object.sh b/t/t5300-pack-object.sh
index 9c68b99..8e3db12 100755
--- a/t/t5300-pack-object.sh
+++ b/t/t5300-pack-object.sh
@@ -457,6 +457,32 @@ test_expect_success !PTHREADS,C_LOCALE_OUTPUT 'pack-objects --threads=N or pack.
 	grep -F "no threads support, ignoring pack.threads" err
 '
 
+lcut () {
+	perl -e '$/ = undef; $_ = <>; s/^.{'$1'}//s; print $_'
+}
+
+test_expect_success 'filtering by size works with multiple excluded' '
+	rm -rf server &&
+	git init server &&
+	printf a > server/a &&
+	printf b > server/b &&
+	printf c-very-long-file > server/c &&
+	printf d-very-long-file > server/d &&
+	git -C server add a b c d &&
+	git -C server commit -m x &&
+
+	git -C server rev-parse HEAD >objects &&
+	git -C server pack-objects --revs --stdout --filter=blob:limit=10 <objects >my.pack &&
+
+	# Ensure that only the small blobs are in the packfile
+	git index-pack my.pack &&
+	git verify-pack -v my.idx >objectlist &&
+	grep $(git hash-object server/a) objectlist &&
+	grep $(git hash-object server/b) objectlist &&
+	! grep $(git hash-object server/c) objectlist &&
+	! grep $(git hash-object server/d) objectlist
+'
+
 #
 # WARNING!
 #
diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
index 1701fe2..07b79c7 100644
--- a/t/test-lib-functions.sh
+++ b/t/test-lib-functions.sh
@@ -1020,3 +1020,15 @@ nongit () {
 		"$@"
 	)
 }
+
+# Converts big-endian pairs of hexadecimal digits into bytes. For example,
+# "printf 61620d0a | hex_pack" results in "ab\r\n".
+hex_pack () {
+	perl -e '$/ = undef; $input = <>; print pack("H*", $input)'
+}
+
+# Converts bytes into big-endian pairs of hexadecimal digits. For example,
+# "printf 'ab\r\n' | hex_unpack" results in "61620d0a".
+hex_unpack () {
+	perl -e '$/ = undef; $input = <>; print unpack("H2" x length($input), $input)'
+}
-- 
2.9.3
Previous: Jeff HostetlerNext: Jeff Hostetler
Message 5 of 15 in “Parial clone part 3: clone, fetch, fetch-pack, upload-pack, and tests”
  1. 00/14 Parial clone part 3: clone, fetch, fetch-pack, upload-pack, and testsJeff Hostetler, Nov 21, 2017
  2. 01/14 upload-pack: add object filtering for partial cloneJeff Hostetler, Nov 21, 2017
  3. 04/14 fetch: add object filtering for partial fetchJeff Hostetler, Nov 21, 2017
  4. 09/14 fetch: add from_promisor and exclude-promisor-objects parametersJeff Hostetler, Nov 21, 2017
  5. 06/14 pack-objects: test support for blob filteringJeff Hostetler, Nov 21, 2017
  6. 05/14 remote-curl: add object filtering for partial cloneJeff Hostetler, Nov 21, 2017
  7. 07/14 fetch-pack: test support excluding large blobsJeff Hostetler, Nov 21, 2017
  8. 08/14 partial-clone: define partial clone settings in configJeff Hostetler, Nov 21, 2017
  9. 10/14 t5500: add fetch-pack tests for partial cloneJeff Hostetler, Nov 21, 2017
  10. 12/14 t5500: more tests for partial clone and fetchJeff Hostetler, Nov 21, 2017
  11. 11/14 t5601: test for partial cloneJeff Hostetler, Nov 21, 2017
  12. 14/14 fetch-pack: restore save_commit_buffer after useJeff Hostetler, Nov 21, 2017
  13. 13/14 unpack-trees: batch fetching of missing blobsJeff Hostetler, Nov 21, 2017
  14. 02/14 clone, fetch-pack, index-pack, transport: partial cloneJeff Hostetler, Nov 21, 2017
  15. 03/14 fetch: refactor calculation of remote listJeff Hostetler, Nov 21, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.