Re: [PATCH] notes: fix erroneous "git notes prune [-n | -v]" message

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Nov 21, 2017, 17:58 UTC
Message-ID: <20171121175846.GB27041@aiede.mtv.corp.google.com>
In-Reply-To: <alpine.LFD.2.21.1711211156110.10397@DESKTOP-1GPMCEJ>

Hi,

Robert P. J. Day wrote:

Show 14 quoted lines

> It seems clear that the man page SYNPOSIS and the usage message
> referring to:
>
>   git notes prune [-n | -v]
>
> is incorrect, as "-n" (dry run) and "-v" (verbose) are not
> alternatives, so fix both places to refer to:
>
>   git notes prune [-n] [-v | -q]
>
> to match the rest of the man page.
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> ---

Hm.  What does "git notes prune -q" do?

The docs describe what --dry-run and --verbose do for "git notes prune" but its description of --quiet seems to be specific to "git notes merge". Should the usage summary be

 git notes [--ref=<notes-ref>] prune [-n] [-v]

instead?  That would also be consistent with "git notes prune -h":

  $ git notes prune -h
  usage: git notes prune [<options>]

      -n, --dry-run         do not remove, show only
      -v, --verbose         report pruned notes

Thanks, Jonathan