Re: [PATCH] contrib/git-jump: allow to configure the grep command
- From
Jeff King <peff@peff.net>
- Date
- Nov 20, 2017, 19:18 UTC
- Message-ID
- <20171120191846.pco4wfsu2ptci3uv@sigill.intra.peff.net>
- In-Reply-To
- <xmqqh8tpmypa.fsf@gitster.mtv.corp.google.com>
On Mon, Nov 20, 2017 at 12:11:13PM +0900, Junio C Hamano wrote:
Show 16 quoted lines
> Beat Bolli <dev+git@drbeat.li> writes: > > > Add the configuration option "jump.grepCmd" that allows to configure the > > command that is used to search in grep mode. This allows the users of > > git-jump to use ag(1) or ack(1) as search engines. > > > > Signed-off-by: Beat Bolli <dev+git@drbeat.li> > > --- > > Thanks. The contrib/README file has this to say (also read the > surrounding text): > > ... If > you have patches to things in contrib/ area, the patch should be > first sent to the primary author, and then the primary author > should ack and forward it to me (git pull request is nicer).
I'm not sure the "ack and forward" and "pull request" bits necessarily make sense here, as I do not host git-jump as a separate repository. I'd expect people to send to the list and cc me, and you'd pick it up as long as I'd ack'd it.
But I'm happy to revisit that if you prefer to do it a different way. We could even pull it out of contrib/ entirely and I could just host it as a separate project entirely.
Show 6 quoted lines
> Peff, I think we need a clear indication in contrib/git-jump/README > to whom patches to the area should be sent. I know how to run > > $ git shortlog -n --no-merges contrib/git-jump > > but not everybody does (or bothers).
How about this?
-- >8 -- Subject: [PATCH] git-jump: give contact instructions in the README
Let's make it clear how patches should flow into contrib/git-jump. The normal Git maintainer does not necessarily care about things in contrib/, and authors of individual components should be the ones giving the final review/ack for a patch. Ditto for bug reports, which are likely to get more attention from the area expert.
Signed-off-by: Jeff King <peff@peff.net> --- contrib/git-jump/README | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/contrib/git-jump/README b/contrib/git-jump/README index 225e3f0954..4257cef2e6 100644 --- a/contrib/git-jump/README +++ b/contrib/git-jump/README @@ -92,3 +92,10 @@ how to activate it. The shell snippets to generate the quickfix lines will almost certainly choke on filenames with exotic characters (like newlines). + +Contributing +------------ + +Bug fixes, bug reports, and feature requests should be discussed on the +Git mailing list <git@vger.kernel.org>, and cc'd to the git-jump +maintainer, Jeff King <peff@peff.net>.
-- 2.15.0.494.g79a8547723