git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/4] sequencer: warn when internal merge may be suboptimal due to renameLimit

From
Elijah Newren <newren@gmail.com>
Date
Nov 13, 2017, 20:15 UTC
Message-ID
<20171113201600.24878-2-newren@gmail.com>
In-Reply-To
<20171113201600.24878-1-newren@gmail.com>

When many files were renamed, the recursive merge strategy stopped detecting renames and left many paths with delete/modify conflicts, without any warning about what was going on or providing any hints about how to tell Git to spend more cycles to detect renames.

Signed-off-by: Elijah Newren <newren@gmail.com>
---
 sequencer.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/sequencer.c b/sequencer.c
index f2a10cc4f2..2b4cecb617 100644
--- a/sequencer.c
+++ b/sequencer.c
@@ -462,6 +462,7 @@ static int do_recursive_merge(struct commit *base, struct commit *next,
 	if (is_rebase_i(opts) && clean <= 0)
 		fputs(o.obuf.buf, stdout);
 	strbuf_release(&o.obuf);
+	diff_warn_rename_limit("merge.renamelimit", o.needed_rename_limit, 0);
 	if (clean < 0)
 		return clean;
 
-- 
2.15.0.44.gf995e411c7
Previous: Elijah NewrenNext: Elijah Newren
Message 2 of 8 in “Fix issues with rename detection limits”
  1. 0/4 Fix issues with rename detection limitsElijah Newren, Nov 13, 2017
  2. 1/4 sequencer: warn when internal merge may be suboptimal due to renameLimitElijah Newren, Nov 13, 2017
  3. 3/4 Remove silent clamp of renameLimitElijah Newren, Nov 13, 2017
  4. 2/4 progress: fix progress meters when dealing with lots of workElijah Newren, Nov 13, 2017
  5. Jonathan TanNov 13, 2017
  6. Jonathan TanNov 13, 2017
  7. Elijah NewrenNov 13, 2017
  8. 4/4 sequencer: show rename progress during cherry picksElijah Newren, Nov 13, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.