[PATCH] bisect run: die if no command is given
- From
Stephan Beyer <s-beyer@gmx.net>
- Date
- Nov 12, 2017, 20:55 UTC
- Message-ID
- <20171112205533.9593-1-s-beyer@gmx.net>
It was possible to invoke "git bisect run" without any command. This considers all commits as good commits since "$@"'s return value for empty $@ is 0.
This is most probably not what a user wants (otherwise she would invoke "git bisect run true"), so not providing a command now results in an error.
Signed-off-by: Stephan Beyer <s-beyer@gmx.net> --- git-bisect.sh | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/git-bisect.sh b/git-bisect.sh index 0138a8860..a69e43656 100755 --- a/git-bisect.sh +++ b/git-bisect.sh @@ -450,6 +450,8 @@ bisect_replay () { bisect_run () { bisect_next_check fail + test -n "$*" || die "$(gettext "bisect run failed: no command provided.")" + while true do command="$@"
-- 2.15.0.165.g0dc13a7db.dirty