Re: [RFC PATCH] rebisect: add script for easier bisect log editing

From: Adam Dinwoodie <adam@dinwoodie.org>
Date: Nov 8, 2017, 16:32 UTC
Message-ID: <20171108163250.GE20681@dinwoodie.org>
In-Reply-To: <CAP8UFD015i76L4BgSZdr2k2TZk+C0vRAqOsj4DaqtNYuJjtNxQ@mail.gmail.com>

On Wednesday 08 November 2017 at 05:12 pm +0100, Christian Couder wrote:

Show 5 quoted lines

> On Wed, Nov 8, 2017 at 2:59 PM, Adam Dinwoodie <adam@dinwoodie.org> wrote:
> > +git bisect reset HEAD
> 
> I guess that using "reset HEAD" could be cheaper than just "reset" and
> that's the reason you are using it.

Exactly that, yes. I often use `reset HEAD` in my own workflows in the name of speed, and I can't see any disadvantages of doing it here, too.

> > +git bisect start
> 
> Are you sure that this "start" is necessary? The doc says that "reset"
> followed by "replay that-file" should be enough.

It isn't necessary, in that the process works if you skip that command. However, without it, the `git bisect replay` command prints "We are not bisecting" before it does anything else, so having the `bisect start` there explicitly removes that extraneous output.

If the script were integrated into git-bisect itself, it would probably make sense to change that behaviour so the warning isn't printed. (It quite possibly makes sense to remove the warning when running `bisect replay` regardless.) But when writing the stand-alone script I wanted things to work without any changes to the core Git code.