Re: [PATCH v3 6/6] pack-objects: add list-objects filtering

From: Jonathan Tan <jonathantanmy@google.com>
Date: Nov 8, 2017, 00:45 UTC
Message-ID: <20171107164519.eb49377ce11a6b31ab09bf83@google.com>
In-Reply-To: <20171107193546.10017-7-git@jeffhostetler.com>

On Tue, 7 Nov 2017 19:35:46 +0000 Jeff Hostetler <git@jeffhostetler.com> wrote:

> +--filter-ignore-missing:
> +	Ignore missing objects without error.  This may be used with
> +	or without and of the above filtering.

There is a discussion about this parameter (and the corresponding ones in patch 5/6), to which I have just replied:

https://public-inbox.org/git/20171107164118.97cc65c4030de0922b19ddd6@google.com/

Show 7 quoted lines

> @@ -3028,6 +3048,12 @@ int cmd_pack_objects(int argc, const char **argv, const char *prefix)
>  	if (!rev_list_all || !rev_list_reflog || !rev_list_index)
>  		unpack_unreachable_expiration = 0;
>  
> +	if (filter_options.choice) {
> +		if (!pack_to_stdout)
> +			die("cannot use filtering with an indexable pack.");

I'm not sure what an "indexable pack" is - probably a better message is "cannot use --filter without --stdout".