git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] credential-libsecret: unlock locked secrets

From
Dennis Kaarsemaker <dennis@kaarsemaker.net>
Date
Nov 3, 2017, 20:44 UTC
Message-ID
<20171103204449.5268-1-dennis@kaarsemaker.net>
In-Reply-To
<CAOAxMp9H6M+t5RvYiem+kXrY920ZDYvyyYt4GZ7ZnkpXVA_c0g@mail.gmail.com>

Credentials exposed by the secret service DBUS interface may be locked. Setting the SECRET_SEARCH_UNLOCK flag will make the secret service unlock these secrets, possibly prompting the user for credentials to do so. Without this flag, the secret is simply not loaded.

Signed-off-by: Dennis Kaarsemaker <dennis@kaarsemaker.net>
---
 contrib/credential/libsecret/git-credential-libsecret.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/credential/libsecret/git-credential-libsecret.c b/contrib/credential/libsecret/git-credential-libsecret.c
index 4c56979d8a..b4750c9ee8 100644
--- a/contrib/credential/libsecret/git-credential-libsecret.c
+++ b/contrib/credential/libsecret/git-credential-libsecret.c
@@ -104,7 +104,7 @@ static int keyring_get(struct credential *c)
 	items = secret_service_search_sync(service,
 					   SECRET_SCHEMA_COMPAT_NETWORK,
 					   attributes,
-					   SECRET_SEARCH_LOAD_SECRETS,
+					   SECRET_SEARCH_LOAD_SECRETS | SECRET_SEARCH_UNLOCK,
 					   NULL,
 					   &error);
 	g_hash_table_unref(attributes);
-- 
2.15.0-rc2-464-gb5de734
Previous: Yaroslav SapozhnykNext: Mantas Mikulėnas
Message 7 of 8 in “Git libsecret No Unlock Dialog Issue”
  1. Yaroslav SapozhnykNov 2, 2017
  2. Stefan BellerNov 2, 2017
  3. Yaroslav SapozhnykNov 2, 2017
  4. Dennis KaarsemakerNov 2, 2017
  5. Yaroslav SapozhnykNov 2, 2017
  6. Yaroslav SapozhnykNov 3, 2017
  7. credential-libsecret: unlock locked secretsDennis Kaarsemaker, Nov 3, 2017
  8. Mantas MikulėnasNov 6, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.