git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 08/14] fetch: add from_promisor and exclude-promisor-objects parameters

From
JHJeff Hostetler <git@jeffhostetler.com>
Date
Nov 2, 2017, 20:31 UTC
Message-ID
<20171102203129.59417-9-git@jeffhostetler.com>
In-Reply-To
<20171102203129.59417-1-git@jeffhostetler.com>
From: Jonathan Tan <jonathantanmy@google.com>

Teach fetch to use from-promisor and exclude-promisor-objects parameters with sub-commands. Initialize fetch_if_missing global variable.

Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
---
 builtin/fetch.c | 9 ++++++---
 connected.c     | 3 +++
 2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/builtin/fetch.c b/builtin/fetch.c
index 150ca0a..ab53df3 100644
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -19,6 +19,7 @@
 #include "utf8.h"
 #include "packfile.h"
 #include "list-objects-filter-options.h"
+#include "partial-clone-utils.h"
 
 static const char * const builtin_fetch_usage[] = {
 	N_("git fetch [<options>] [<repository> [<refspec>...]]"),
@@ -1048,9 +1049,11 @@ static struct transport *prepare_transport(struct remote *remote, int deepen)
 		set_option(transport, TRANS_OPT_DEEPEN_RELATIVE, "yes");
 	if (update_shallow)
 		set_option(transport, TRANS_OPT_UPDATE_SHALLOW, "yes");
-	if (filter_options.choice)
+	if (filter_options.choice) {
 		set_option(transport, TRANS_OPT_LIST_OBJECTS_FILTER,
 			   filter_options.raw_value);
+		set_option(transport, TRANS_OPT_FROM_PROMISOR, "1");
+	}
 	return transport;
 }
 
@@ -1290,7 +1293,6 @@ static int fetch_multiple(struct string_list *list)
 
 static inline void partial_fetch_one_setup(struct remote *remote)
 {
-#if 0 /* TODO */
 	if (filter_options.choice) {
 		/*
 		 * A partial-fetch was explicitly requested.
@@ -1325,7 +1327,6 @@ static inline void partial_fetch_one_setup(struct remote *remote)
 			&filter_options,
 			repository_format_partial_clone_filter);
 	}
-#endif
 }
 
 static int fetch_one(struct remote *remote, int argc, const char **argv)
@@ -1392,6 +1393,8 @@ int cmd_fetch(int argc, const char **argv, const char *prefix)
 
 	packet_trace_identity("fetch");
 
+	fetch_if_missing = 0;
+
 	/* Record the command line for the reflog */
 	strbuf_addstr(&default_rla, "fetch");
 	for (i = 1; i < argc; i++)
diff --git a/connected.c b/connected.c
index f416b05..6015316 100644
--- a/connected.c
+++ b/connected.c
@@ -4,6 +4,7 @@
 #include "connected.h"
 #include "transport.h"
 #include "packfile.h"
+#include "partial-clone-utils.h"
 
 /*
  * If we feed all the commits we want to verify to this command
@@ -56,6 +57,8 @@ int check_connected(sha1_iterate_fn fn, void *cb_data,
 	argv_array_push(&rev_list.args,"rev-list");
 	argv_array_push(&rev_list.args, "--objects");
 	argv_array_push(&rev_list.args, "--stdin");
+	if (is_partial_clone_registered())
+		argv_array_push(&rev_list.args, "--exclude-promisor-objects");
 	argv_array_push(&rev_list.args, "--not");
 	argv_array_push(&rev_list.args, "--all");
 	argv_array_push(&rev_list.args, "--quiet");
-- 
2.9.3
Previous: Jeff HostetlerNext: Jeff Hostetler
Message 11 of 23 in “WIP Partial clone part 3: clone, fetch, fetch-pack, upload-pack, and tests”
  1. 00/14 WIP Partial clone part 3: clone, fetch, fetch-pack, upload-pack, and testsJeff Hostetler, Nov 2, 2017
  2. 02/14 clone, fetch-pack, index-pack, transport: partial cloneJeff Hostetler, Nov 2, 2017
  3. Jonathan TanNov 3, 2017
  4. Adam DinwoodieNov 8, 2017
  5. Jeff HostetlerNov 16, 2017
  6. 04/14 fetch: add object filtering for partial fetchJeff Hostetler, Nov 2, 2017
  7. Jonathan TanNov 3, 2017
  8. Jeff HostetlerNov 16, 2017
  9. 05/14 remote-curl: add object filtering for partial cloneJeff Hostetler, Nov 2, 2017
  10. 07/14 fetch-pack: test support excluding large blobsJeff Hostetler, Nov 2, 2017
  11. 08/14 fetch: add from_promisor and exclude-promisor-objects parametersJeff Hostetler, Nov 2, 2017
  12. 10/14 t5601: test for partial cloneJeff Hostetler, Nov 2, 2017
  13. 13/14 fetch-pack: restore save_commit_buffer after useJeff Hostetler, Nov 2, 2017
  14. 11/14 t5500: more tests for partial clone and fetchJeff Hostetler, Nov 2, 2017
  15. 14/14 index-pack: silently assume missing objects are promisorJeff Hostetler, Nov 2, 2017
  16. 12/14 unpack-trees: batch fetching of missing blobsJeff Hostetler, Nov 2, 2017
  17. 09/14 t5500: add fetch-pack tests for partial cloneJeff Hostetler, Nov 2, 2017
  18. 06/14 pack-objects: test support for blob filteringJeff Hostetler, Nov 2, 2017
  19. 03/14 fetch: refactor calculation of remote listJeff Hostetler, Nov 2, 2017
  20. 01/14 upload-pack: add object filtering for partial cloneJeff Hostetler, Nov 2, 2017
  21. Jonathan TanNov 2, 2017
  22. Jeff HostetlerNov 3, 2017
  23. Junio C HamanoNov 3, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.