git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/9] perf/run: add '--config' option to the 'run' script

From
Kevin Daudt <me@ikke.info>
Date
Oct 18, 2017, 10:58 UTC
Message-ID
<20171018105801.GF19335@alpha.vpn.ikke.info>
In-Reply-To
<0102015eb04f8927-439213ae-a464-4638-affa-f0d6484086c0-000000@eu-west-1.amazonses.com>
On Sat, Sep 23, 2017 at 07:55:56PM +0000, Christian Couder wrote:
Show 30 quoted lines
> It is error prone and tiring to use many long environment
> variables to give parameters to the 'run' script.
> 
> Let's make it easy to store some parameters in a config
> file and to pass them to the run script.
> 
> The GIT_PERF_CONFIG_FILE variable will be set to the
> argument of the '--config' option. This variable is not
> used yet. It will be used in a following commit.
> 
> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
>  t/perf/run | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/t/perf/run b/t/perf/run
> index beb4acc0e428d..1e7c2a59e45dc 100755
> --- a/t/perf/run
> +++ b/t/perf/run
> @@ -2,9 +2,14 @@
>  
>  case "$1" in
>  	--help)
> -		echo "usage: $0 [other_git_tree...] [--] [test_scripts]"
> +		echo "usage: $0 [--config file] [other_git_tree...] [--] [test_scripts]"
>  		exit 0
>  		;;
> +	--config)
> +		shift
> +		GIT_PERF_CONFIG_FILE=$(cd "$(dirname "$1")"; pwd)/$(basename "$1")

Is the idea of this construct to do some kind of normalization? Otherwise it seems to just result in $1 again.

Show 8 quoted lines
> +		export GIT_PERF_CONFIG_FILE
> +		shift ;;
>  esac
>  
>  die () {
> 
> --
> https://github.com/git/git/pull/408
Previous: Ævar Arnfjörð BjarmasonNext: Christian Couder
Message 13 of 14 in “perf/run: add '--config' option to the 'run' script”
  1. 1/9 perf/run: add '--config' option to the 'run' scriptChristian Couder, Sep 23, 2017
  2. 4/9 perf/run: add calls to get_var_from_env_or_config()Christian Couder, Sep 23, 2017
  3. 8/9 perf/run: show name of rev being builtChristian Couder, Sep 23, 2017
  4. 9/9 perf: store subsection results in "test-results/$GIT_PERF_SUBSECTION/"Christian Couder, Sep 23, 2017
  5. 2/9 perf/run: add get_var_from_env_or_config()Christian Couder, Sep 23, 2017
  6. 5/9 perf/run: add get_subsections()Christian Couder, Sep 23, 2017
  7. 6/9 perf/run: update get_var_from_env_or_config() for subsectionsChristian Couder, Sep 23, 2017
  8. 3/9 perf/run: add GIT_PERF_DIRS_OR_REVSChristian Couder, Sep 23, 2017
  9. 7/9 perf/run: add run_subsection()Christian Couder, Sep 23, 2017
  10. Junio C HamanoOct 16, 2017
  11. Christian CouderNov 17, 2017
  12. Ævar Arnfjörð BjarmasonNov 24, 2017
  13. Kevin DaudtOct 18, 2017
  14. Christian CouderOct 18, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.