Re: [Alt. PATCH] ls-remote: deprecate -h as short for --heads
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Oct 17, 2017, 17:43 UTC
- Message-ID
- <20171017174350.4dnh3ydoagxgp6xj@aiede.mtv.corp.google.com>
- In-Reply-To
- <774f08bd-3172-0083-1544-e5f68f6798fa@web.de>
René Scharfe wrote:
Show 10 quoted lines
> Stop advertising -h as the short equivalent of --heads, because it's > used for showing a short help text for almost all other git commands. > Since the ba5f28bf79 (ls-remote: use parse-options api) it has only > been working when used together with other parameters anyway. > > Signed-off-by: Rene Scharfe <l.s.r@web.de> > --- > Documentation/git-ls-remote.txt | 1 - > builtin/ls-remote.c | 4 +++- > 2 files changed, 3 insertions(+), 2 deletions(-)
Yes, I think this is a good step. Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
I would be tempted to go even further and make "git ls-remote -h" print a warning to stderr to encourage people to update their scripts to use --heads instead.
Thanks.