Re: [PATCH 3/3] branch: forbid refs/heads/HEAD

From: Jeff King <peff@peff.net>
Date: Oct 16, 2017, 21:38 UTC
Message-ID: <20171016213819.jgx5tihszqngvti2@sigill.intra.peff.net>
In-Reply-To: <xmqqa80uv5b8.fsf@gitster.mtv.corp.google.com>

On Sat, Oct 14, 2017 at 11:20:11AM +0900, Junio C Hamano wrote:

Show 15 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> 
> >> Should we test that:
> >>
> >>   git update-ref refs/heads/HEAD HEAD^
> >>
> >> continues to work?
> >
> > Perhaps.  Also we may want to make sure that "git branch -D HEAD"
> > still works as a way to recover from historical mistakes.
> 
> The only difference is improved tests where we use show-ref to make
> sure refs/heads/HEAD does not exist when it shouldn't, exercise
> update-ref to create and delete refs/heads/HEAD, and also make sure
> it can be deleted with "git branch -d".

Thanks, this looks good to me.

-Peff