Re: git-clone causes out of memory

From: Jeff King <peff@peff.net>
Date: Oct 13, 2017, 13:50 UTC
Message-ID: <20171013135058.q7vhufdtin42ddic@sigill.intra.peff.net>
In-Reply-To: <a4ebf552-35d4-d55f-6f08-731afa2cd2de@gmail.com>

On Fri, Oct 13, 2017 at 09:39:14AM -0400, Derrick Stolee wrote:

Show 18 quoted lines

> Since I don't understand enough about the consumers to diff_tree_oid() (and
> the fact that the recursive behavior may be wanted in some cases), I think
> we can fix this in builtin/rev-list.c with this simple diff:
> 
> ---
> 
> diff --git a/builtin/rev-list.c b/builtin/rev-list.c
> index ded1577424..b2e8e02cc8 100644
> --- a/builtin/rev-list.c
> +++ b/builtin/rev-list.c
> @@ -285,6 +285,9 @@ int cmd_rev_list(int argc, const char **argv, const char
> *prefix)
> 
>         git_config(git_default_config, NULL);
>         init_revisions(&revs, prefix);
> +
> +       revs.pruning.flags = revs.pruning.flags & ~DIFF_OPT_RECURSIVE;
> +

Hmm, this feels wrong, because we _do_ want to recurse down and follow the pathspec to see if there are real changes.

We should be comparing an empty tree and d0/d0/d0/d0 (or however deep your pathspec goes). We should be able to see immediately that the entry is not present between the two and not bother descending. After all, we've set the QUICK flag in init_revisions(). So the real question is why QUICK is not kicking in.

-Peff