Re: [RFC PATCH 2/4] change submodule push test to use proper repository setup

From: Josh Triplett <josh@joshtriplett.org>
Date: Oct 11, 2017, 15:10 UTC
Message-ID: <20171011151021.o6f4l7kcd3azdmiu@x>
In-Reply-To: <CAGZ79kZFtMxD8wf59SViOOc_mrhwTVr6v0ucAePp+-8hg_im-Q@mail.gmail.com>

On Tue, Oct 10, 2017 at 11:39:21AM -0700, Stefan Beller wrote:

Show 10 quoted lines

> On Tue, Oct 10, 2017 at 6:03 AM, Heiko Voigt <hvoigt@hvoigt.net> wrote:
> > but in the long run my goal
> > for submodules is and always was: Make them behave as close to files as
> > possible. And why should a 'git add submodule' not magically do
> > everything it can to make submodules just work? I can look into a patch
> > for that if people agree here...
> 
> I'd love to see this implemented. I cc'd Josh (the author of git-series), who
> may disagree with this, or has some good input how to go forward without
> breaking git-series.

git-series doesn't use the git-submodule command at all, nor does it construct series trees using git-add or any other git command-line tool; it constructs gitlinks directly. Most of the time, it doesn't even make sense to `git checkout` a series branch. Modifying commands like git-add and similar to automatically manage .gitmodules won't cause any issue at all, as long as git itself doesn't start rejecting or complaining about repositories that have gitlinks without a .gitmodules file.

- Josh Triplett