Re: [PATCH] submodule: spell out API of submodule_move_head
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Oct 9, 2017, 22:22 UTC
- Message-ID
- <20171009222224.GD19555@aiede.mtv.corp.google.com>
- In-Reply-To
- <20171009220615.27541-1-sbeller@google.com>
Stefan Beller wrote:
Show 9 quoted lines
> This way users of this function do not need to read the implementation to > know what it will do. > > Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> > Signed-off-by: Stefan Beller <sbeller@google.com> > --- > submodule.c | 5 ----- > submodule.h | 18 ++++++++++++++++++ > 2 files changed, 18 insertions(+), 5 deletions(-)
Looks good (well, you'd expect me to think that :)). Thanks.