git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 3/4] sha1_name: parse less while finding common prefix

From
Jeff King <peff@peff.net>
Date
Oct 9, 2017, 13:42 UTC
Message-ID
<20171009134253.y2chrtd2hjaaaimm@sigill.intra.peff.net>
In-Reply-To
<20171008184942.69444-4-dstolee@microsoft.com>
On Sun, Oct 08, 2017 at 02:49:41PM -0400, Derrick Stolee wrote:
Show 10 quoted lines
> +static inline char get_hex_char_from_oid(const struct object_id *oid,
> +					 int pos)
> +{
> +	static const char hex[] = "0123456789abcdef";
> +
> +	if ((pos & 1) == 0)
> +		return hex[oid->hash[pos >> 1] >> 4];
> +	else
> +		return hex[oid->hash[pos >> 1] & 0xf];
> +}

Should "pos" be unsigned? I don't think it matters much in practice (as long as it's not negative, the results are well defined by the standard, and this clearly will be between 0 and 40). But it seems funny that we consistently use unsigned in the rest of the caller and then implicitly convert to signed here.

-Peff
Previous: Derrick StoleeNext: Derrick Stolee
Message 4 of 22 in “Improve abbreviation disambiguation”
  1. 0/4 Improve abbreviation disambiguationDerrick Stolee, Oct 8, 2017
  2. 1/4 p4211-line-log.sh: add log --online --raw --parents perf testDerrick Stolee, Oct 8, 2017
  3. 3/4 sha1_name: parse less while finding common prefixDerrick Stolee, Oct 8, 2017
  4. Jeff KingOct 9, 2017
  5. 4/4 sha1_name: minimize OID comparisons during disambiguationDerrick Stolee, Oct 8, 2017
  6. Jeff KingOct 9, 2017
  7. Derrick StoleeOct 10, 2017
  8. Jeff KingOct 10, 2017
  9. Junio C HamanoOct 10, 2017
  10. Jeff KingOct 10, 2017
  11. Derrick StoleeOct 10, 2017
  12. Jeff KingOct 10, 2017
  13. Derrick StoleeOct 11, 2017
  14. 0/4 Improve abbreviation disambiguationDerrick Stolee, Oct 12, 2017
  15. Derrick StoleeOct 12, 2017
  16. Junio C HamanoOct 12, 2017
  17. Jeff KingOct 12, 2017
  18. 3/4 sha1_name: parse less while finding common prefixDerrick Stolee, Oct 12, 2017
  19. 2/4 sha1_name: unroll len loop in find_unique_abbrev_rDerrick Stolee, Oct 12, 2017
  20. 1/4 p4211-line-log.sh: add log --online --raw --parents perf testDerrick Stolee, Oct 12, 2017
  21. 4/4 sha1_name: minimize OID comparisons during disambiguationDerrick Stolee, Oct 12, 2017
  22. 2/4 sha1_name: unroll len loop in find_unique_abbrev_rDerrick Stolee, Oct 8, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.