Re: [ANNOUNCE] Git v2.15.0-rc0

From: Jeff King <peff@peff.net>
Date: Oct 5, 2017, 06:09 UTC
Message-ID: <20171005060922.o2wzccm4uqq5o74e@sigill.intra.peff.net>
In-Reply-To: <xmqq7ewa87fw.fsf@gitster.mtv.corp.google.com>

On Thu, Oct 05, 2017 at 02:55:31PM +0900, Junio C Hamano wrote:

Show 12 quoted lines

> Git 2.15 Release Notes (draft)
> ==============================
> 
> Backward compatibility notes and other notable changes.
> 
>  * Use of an empty string as a pathspec element that is used for
>    'everything matches' is still warned and Git asks users to use a
>    more explicit '.' for that instead.  The hope is that existing
>    users will not mind this change, and eventually the warning can be
>    turned into a hard error, upgrading the deprecation into removal of
>    this (mis)feature.  That is now scheduled to happen in the upcoming
>    release.

I wasn't sure if this "upcoming" meant v2.15 ("the upcoming release that we're about to tag") or v2.16. Judging from "What's cooking" it's the latter, but perhaps we should be more explicit. I don't know if you are hesitant to name it "v2.16" at this point, but maybe:

  ...in the upcoming release (i.e., the one after v2.15).

would help.

>  * Git now avoids blindly falling back to ".git" when the setup
>    sequence said we are _not_ in Git repository.  A corner case that
>    happens to work right now may be broken by a call to die("BUG").

An even more minor nit. This is now BUG(). :)

I don't think it matters for our purposes here, of course. But I did wonder how long we'd want to carry this warning in the notes. I think it goes back to v2.13. Of course people sometimes jump several versions without necessarily reading the interim release notes, so it makes sense to carry it for a while.

-Peff