Re: [PATCH 2/3] http-push: fix construction of hex value from path
- From
Jeff King <peff@peff.net>
- Date
- Oct 4, 2017, 05:26 UTC
- Message-ID
- <20171004052640.3sxpluokhcyh4c2y@sigill.intra.peff.net>
- In-Reply-To
- <xmqqy3orcwvu.fsf@gitster.mtv.corp.google.com>
On Wed, Oct 04, 2017 at 02:20:05PM +0900, Junio C Hamano wrote:
Show 20 quoted lines
> Junio C Hamano <gitster@pobox.com> writes: > > > Jeff King <peff@peff.net> writes: > > > >>> Moreover, this is in the webdav-based "dumb http" push code path, > >>> which I do not trust much at all. I wonder if we could retire it > >>> completely (or at least provide an option to turn it off). > >> > >> I would really like that, too. It has been the cause of a lot of pain > >> when working with the smart code, and I am not at all surprised to find > >> a bug of this magnitude lurking in it. I'd _hoped_ this could show that > >> the system has been unusably broken for years, which would give us > >> confidence to turn it off. :) But per your paragraph above, people could > >> very easily still have been happily using it in the meantime. > > > > Same here. Perhaps we should deliberately and silently break it and > > see who screams? > > Hopefully it should be obvious but just for people with unreasonable > expectations, I should clarify that the above needs a smiley ;-).
Yes, I was surprised to see it without one. :)
More seriously, is there any interest in marking it as deprecated in the release notes and issuing a warning when it's used for a few cycles?
-Peff