Re: git add -p stops working when setting color.ui = always

From: Kevin Daudt <me@ikke.info>
Date: Oct 3, 2017, 19:36 UTC
Message-ID: <20171003193651.GB1667@alpha.vpn.ikke.info>
In-Reply-To: <CAB2yay8LLeNbqR4kkTwF1U+oarVDRxgkV4uGXuYcO8mAQmhWQQ@mail.gmail.com>

On Mon, Oct 02, 2017 at 01:38:17PM +0300, Tsvi Mostovicz wrote:

Show 14 quoted lines

> Hi,
> 
> When setting "color.ui = always" in the last few versions (not sure
> exactly when this started, but definitely exists in 2.14.1 and
> 2.14.2), git add -p stops working as expected. Instead of prompting
> the user, it skips through the prompts and doesn't allow selecting a
> hunk.
> 
> Don't know why I had color.ui = always set in my .gitconfig.
> 
> git version 2.14.2.666.gea220ee40
> 
> Thanks,
>

Hello Tsvi,

This is being discussed just now[0]. Setting the value to auto should fix it (setting it to always does not make much sense in your config file).

Kevin.

[0}:https://public-inbox.org/git/20171003093157.gq7za2fwcqsouire@sigill.intra.peff.net/T/