Re: [PATCHv2] Documentation/config: clarify the meaning of submodule.<name>.update
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Sep 22, 2017, 22:58 UTC
- Message-ID
- <20170922225855.GM27425@aiede.mtv.corp.google.com>
- In-Reply-To
- <20170922225250.19705-1-sbeller@google.com>
Stefan Beller wrote:
Show 7 quoted lines
> Reported-by: Lars Schneider <larsxschneider@gmail.com> > Signed-off-by: Stefan Beller <sbeller@google.com> > --- > Documentation/config.txt | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > Jonathan writes:
Show 17 quoted lines
>> You'll want to update Documentation/gitmodules.txt, too. > > No. /grumpycat > > It should already be fine, as I read it as if it is only relevant to > "git submodule update" there, already: > > submodule.<name>.update:: > Defines the default update procedure for the named submodule, > i.e. how the submodule is updated by "git submodule update" > command in the superproject. This is only used by `git > submodule init` to initialize the configuration variable of > the same name. Allowed values here are 'checkout', 'rebase', > 'merge' or 'none'. See description of 'update' command in > linkgit:git-submodule[1] for their meaning. Note that the > '!command' form is intentionally ignored here for security > reasons.
I disagree. Actually, I think the git-config(1) blurb could just point here, and that the text here ought to be clear about what commands it affects and how an end user would use it.