git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/4] cache.h: hex2chr() - avoid -Wsign-compare warnings

From
Jeff King <peff@peff.net>
Date
Sep 22, 2017, 16:22 UTC
Message-ID
<20170922162251.kx2w5u4falztcpnh@sigill.intra.peff.net>
In-Reply-To
<20170922161817.iy5tpexouxn5uwsb@sigill.intra.peff.net>
On Fri, Sep 22, 2017 at 12:18:17PM -0400, Jeff King wrote:
Show 6 quoted lines
> > I think if this function is fed an empty string that it will also read
> > past the end of the buffer for in[1]. It shouldn't matter, since the NUL
> > in in[0] would cause us to return an error regardless, but it's still
> > undefined behavior.
> 
> This is still a bug, though.
Last message, I promise. ;)

I started on the minimal fix for this, but actually it's OK by virtue of its sole caller first checking that we have enough length (because we're not parsing a string, in fact, but a ptr/len buffer).

So all is well, though I think get_hex_color() does serve as a poor example if somebody were to try to adapt it generally (hopefully they wouldn't, since hex2chr() is already globally available).

Sorry for the all the noise.
-Peff
Previous: Jeff KingNext: Ramsay Jones
Message 6 of 8 in “cache.h: hex2chr() - avoid -Wsign-compare warnings”
  1. 3/4 cache.h: hex2chr() - avoid -Wsign-compare warningsRamsay Jones, Sep 21, 2017
  2. Jeff KingSep 22, 2017
  3. Ramsay JonesSep 22, 2017
  4. Jeff KingSep 22, 2017
  5. Jeff KingSep 22, 2017
  6. Jeff KingSep 22, 2017
  7. Ramsay JonesSep 22, 2017
  8. René ScharfeSep 22, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.