git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] commit: fix memory leak in `reduce_heads()`

From
Jeff King <peff@peff.net>
Date
Sep 20, 2017, 20:15 UTC
Message-ID
<20170920201532.paynyzq7ln7cadqc@sigill.intra.peff.net>
In-Reply-To
<1505936846-2195-3-git-send-email-martin.agren@gmail.com>
On Wed, Sep 20, 2017 at 09:47:25PM +0200, Martin Ågren wrote:
> We don't free the temporary scratch space we use with
> `remove_redundant()`. Free it similar to how we do it in
> `get_merge_bases_many_0()`.

Yep, seems very straightforward, and there are no code paths where we wouldn't want this.

-Peff
Previous: Martin ÅgrenNext: Jonathan Nieder
Message 2 of 3 in “commit: fix memory leak in `reduce_heads()`”
  1. commit: fix memory leak in `reduce_heads()`Martin Ågren, Sep 20, 2017
  2. Jeff KingSep 20, 2017
  3. Jonathan NiederSep 20, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.