Re: [PATCH 0/3] Improve abbreviation disambiguation

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sep 15, 2017, 17:08 UTC
Message-ID: <20170915170857.GS27425@aiede.mtv.corp.google.com>
In-Reply-To: <20170915165750.198201-1-dstolee@microsoft.com>

Hi,

Derrick Stolee wrote:

> This is my first patch submission, and I look forward to your feedback.

Thanks for writing this.  Looks exciting.

[...]

> When displaying object ids, we frequently want to see an abbreviation

[etc]

> Note that performance improves in all cases, but the performance gain
> is larger when there are multiple, large pack-files. This gain comes
> from the lack of in-memory caching of index files that have already been
> inspected.

Can this (especially the performance information) go in the commit message for one of the patches?

Otherwise it is harder for people to track down when looking at these changes later with "git log". In the worst case, if the mailing list archive is down, then people would not have access to this information at all. For that reason, I try (though I often fail!) to restrict cover letters to giving hints at e.g. what changed since the patch series last visited the list, and to make the commit messages in the patches themselves as self-contained as possible.

That aside, looking forward to reading the patches themselves in more detail. Thanks for working on this.

Sincerely, Jonathan