git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 25/40] external-odb: add 'get_direct' support

From
JTJonathan Tan <jonathantanmy@google.com>
Date
Sep 15, 2017, 20:54 UTC
Message-ID
<20170915135452.4289d591@twelve2.svl.corp.google.com>
In-Reply-To
<CAP8UFD0-myJuhBQhZoBiQ6cE4FEkzzuro-sZeDfCN-HK_LxriQ@mail.gmail.com>

On Fri, 15 Sep 2017 13:24:50 +0200 Christian Couder <christian.couder@gmail.com> wrote:

Show 15 quoted lines
> > There are still some nuances. For example, if an external ODB provides
> > both a tree and a blob that the tree references, do we fetch the tree in
> > order to call "have" on all its blobs, or do we trust the ODB that if it
> > has the tree, it has all the other objects? In my design, I do the
> > latter, but in the general case where we have multiple ODBs, we might
> > have to do the former. (And if we do the former, it seems to me that the
> > connectivity check must be performed "online" - that is, with the ODBs
> > being able to provide "get".)
> 
> Yeah, I agree that the problem is more complex if there can be trees
> or all kind of objects in the external odb.
> But as I explain in the following email to Junio, I don't think
> storing other kind of objects is one of the most interesting use case:
> 
> https://public-inbox.org/git/CAP8UFD3=nuTRF24CLSoK4HSGm3nxGh8SbZVpMCg7cNcHj2zkBA@mail.gmail.com/

If we start with only blobs in the ODB, that makes sense (the ODB will need to supply a fast enough "list" or "have", but, as you wrote before, a mechanism like fetching an additional ref that contains all the necessary information whenever we fetch refs would be enough). I agree that it would work with existing use cases (including yours).

Show 10 quoted lines
> > (Also, my work extends all the way to fetch/clone [1], but admittedly I
> > have been taking it a step at a time and recently have only been
> > discussing how the local repo should handle the missing object
> > situation.)
> >
> > [1] https://public-inbox.org/git/cover.1499800530.git.jonathantanmy@google.com/
> 
> Yeah, I think your work is interesting and could perhaps be useful for
> external odbs as there could be situations that would be handled
> better using your work or something similar.
Thanks.
Previous: Christian CouderNext: Christian Couder
Message 56 of 73 in “Add initial experimental external ODB support”
  1. 00/40 Add initial experimental external ODB supportChristian Couder, Aug 3, 2017
  2. 03/40 t0021/rot13-filter: improve 'if .. elsif .. else' styleChristian Couder, Aug 3, 2017
  3. 04/40 Add Git/Packet.pm from parts of t0021/rot13-filter.plChristian Couder, Aug 3, 2017
  4. Junio C HamanoAug 3, 2017
  5. Christian CouderAug 4, 2017
  6. 07/40 Git/Packet.pm: add packet_initialize()Christian Couder, Aug 3, 2017
  7. 09/40 sha1_file: prepare for external odbsChristian Couder, Aug 3, 2017
  8. 11/40 odb-helper: add odb_helper_init() to send 'init' instructionChristian Couder, Aug 3, 2017
  9. Lars SchneiderSep 10, 2017
  10. Christian CouderSep 14, 2017
  11. 14/40 external-odb: accept only blobs for nowChristian Couder, Aug 3, 2017
  12. Junio C HamanoAug 3, 2017
  13. Christian CouderSep 14, 2017
  14. 12/40 t0400: add 'put_raw_obj' instruction to odb-helper scriptChristian Couder, Aug 3, 2017
  15. Lars SchneiderSep 10, 2017
  16. Christian CouderSep 14, 2017
  17. 20/40 lib-httpd: add list.shChristian Couder, Aug 3, 2017
  18. 13/40 external odb: add 'put_raw_obj' supportChristian Couder, Aug 3, 2017
  19. Junio C HamanoAug 3, 2017
  20. Christian CouderSep 14, 2017
  21. 22/40 odb-helper: add odb_helper_get_raw_object()Christian Couder, Aug 3, 2017
  22. 19/40 lib-httpd: add upload.shChristian Couder, Aug 3, 2017
  23. Junio C HamanoAug 3, 2017
  24. Christian CouderSep 14, 2017
  25. 21/40 lib-httpd: add apache-e-odb.confChristian Couder, Aug 3, 2017
  26. 29/40 Add t0460 to test passing git objectsChristian Couder, Aug 3, 2017
  27. 28/40 Add t0450 to test 'get_direct' mechanismChristian Couder, Aug 3, 2017
  28. 33/40 Add t0480 to test "have" capability and raw objectsChristian Couder, Aug 3, 2017
  29. 34/40 external-odb: use 'odb=magic' attribute to mark odb blobsChristian Couder, Aug 3, 2017
  30. 37/40 clone: add --initial-refspec optionChristian Couder, Aug 3, 2017
  31. 36/40 clone: add 'initial' param to write_remote_refs()Christian Couder, Aug 3, 2017
  32. 35/40 Add Documentation/technical/external-odb.txtChristian Couder, Aug 3, 2017
  33. Stefan BellerAug 3, 2017
  34. Christian CouderAug 25, 2017
  35. Jonathan TanAug 25, 2017
  36. Christian CouderAug 29, 2017
  37. Ben PeartAug 28, 2017
  38. Christian CouderAug 29, 2017
  39. Ben PeartAug 30, 2017
  40. Christian CouderAug 30, 2017
  41. 30/40 odb-helper: add put_object_process()Christian Couder, Aug 3, 2017
  42. 32/40 odb-helper: add have_object_process()Christian Couder, Aug 3, 2017
  43. 38/40 clone: disable external odb before initial cloneChristian Couder, Aug 3, 2017
  44. 39/40 Add tests for 'clone --initial-refspec'Christian Couder, Aug 3, 2017
  45. 40/40 Add t0430 to test cloning using bundlesChristian Couder, Aug 3, 2017
  46. 31/40 Add t0470 to test passing raw objectsChristian Couder, Aug 3, 2017
  47. 27/40 odb-helper: add init_object_process()Christian Couder, Aug 3, 2017
  48. 23/40 pack-objects: don't pack objects in external odbsChristian Couder, Aug 3, 2017
  49. 26/40 odb-helper: add 'script_mode' to 'struct odb_helper'Christian Couder, Aug 3, 2017
  50. 24/40 Add t0420 to test transfer to HTTP external odbChristian Couder, Aug 3, 2017
  51. 25/40 external-odb: add 'get_direct' supportChristian Couder, Aug 3, 2017
  52. Junio C HamanoAug 3, 2017
  53. Christian CouderSep 14, 2017
  54. Jonathan TanSep 14, 2017
  55. Christian CouderSep 15, 2017
  56. Jonathan TanSep 15, 2017
  57. 15/40 t0400: add test for external odb write supportChristian Couder, Aug 3, 2017
  58. 17/40 Add t0410 to test external ODB transferChristian Couder, Aug 3, 2017
  59. 18/40 lib-httpd: pass config file to start_httpd()Christian Couder, Aug 3, 2017
  60. 16/40 Add GIT_NO_EXTERNAL_ODB env variableChristian Couder, Aug 3, 2017
  61. 10/40 Add initial external odb supportChristian Couder, Aug 3, 2017
  62. Junio C HamanoAug 3, 2017
  63. Jeff KingAug 3, 2017
  64. Christian CouderSep 14, 2017
  65. 08/40 Git/Packet.pm: add capability functionsChristian Couder, Aug 3, 2017
  66. Junio C HamanoAug 3, 2017
  67. Christian CouderAug 4, 2017
  68. 01/40 builtin/clone: get rid of 'value' strbufChristian Couder, Aug 3, 2017
  69. 05/40 t0021/rot13-filter: use Git/Packet.pmChristian Couder, Aug 3, 2017
  70. 06/40 Git/Packet.pm: improve error messageChristian Couder, Aug 3, 2017
  71. 02/40 t0021/rot13-filter: refactor packet reading functionsChristian Couder, Aug 3, 2017
  72. Lars SchneiderSep 10, 2017
  73. Christian CouderSep 14, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.