Re: [PATCH v2] test-lib: don't use ulimit in test prerequisites on cygwin

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sep 14, 2017, 18:24 UTC
Message-ID: <20170914182407.GA78683@aiede.mtv.corp.google.com>
In-Reply-To: <580fd1db-2506-42bc-4b6e-3636e21fb4cf@ramsayjones.plus.com>

Ramsay Jones wrote:

Show 17 quoted lines

> On cygwin (and MinGW), the 'ulimit' built-in bash command does not have
> the desired effect of limiting the resources of new processes, at least
> for the stack and file descriptors. However, it always returns success
> and leads to several test prerequisites being erroneously set to true.
>
> Add a check for cygwin and MinGW to the prerequisite expressions, using
> a 'test_have_prereq !MINGW,!CYGWIN' clause, to guard against using ulimit.
> This affects the prerequisite expressions for the ULIMIT_STACK_SIZE,
> CMDLINE_LIMIT and ULIMIT_FILE_DESCRIPTORS prerequisites.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>  t/t1400-update-ref.sh |  5 ++++-
>  t/t6120-describe.sh   |  1 -
>  t/t7004-tag.sh        |  1 -
>  t/test-lib.sh         | 10 ++++++++--
>  4 files changed, 12 insertions(+), 5 deletions(-)

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thank you.