Re: Buffered value should be shown when requesting username for remote authentication

From: Jeff King <peff@peff.net>
Date: Sep 12, 2017, 15:33 UTC
Message-ID: <20170912153355.mbsybuy3kqtfvmtd@sigill.intra.peff.net>
In-Reply-To: <1505220449.27800.23.camel@gmail.com>

On Tue, Sep 12, 2017 at 06:17:29PM +0530, Kaartic Sivaraam wrote:

Show 13 quoted lines

> I noted a little issue with the interaction to a remote git repository.
> The issue occurs when the network used for remote communication is a
> bit sluggish. The main issue is illustrated by the following shell
> interaction,
> 
>     $ git push -u fork 
>     sivaraamUsername for '    https://github.com'    : sivaraam
>     Password for '    https://sivaraamsivaraam@github.com':     
> 
>     It's a little odd that the (buffered) input found before the request
>     for 'Username' is also appended to the input found after the request.
>     This might not be obvious to the user and he has to retype the
>     'Username' in the next try.

If I understand right, you typed "sivaraam" once, then the network lagged, then you typed "sivaraam" again.

That isn't really something that Git can fix reliably. Reading those characters and echoing them back to the terminal is handled by your terminal driver (and potentially other things like ssh). Git may have received "sivaraamsivaraam" all at once, depending on where the lag is.

-Peff