Re: BUG: attempt to trim too many characters
- From
Jeff King <peff@peff.net>
- Date
- Sep 5, 2017, 21:50 UTC
- Message-ID
- <20170905215056.4wihyd6hrtvk52yd@sigill.intra.peff.net>
- In-Reply-To
- <CA+55aFxW3qcETiMrNk5SqZU+_jtM2Rxeb3mhF=J=c0ChdGm1tg@mail.gmail.com>
On Tue, Sep 05, 2017 at 02:39:05PM -0700, Linus Torvalds wrote:
Show 20 quoted lines
> I just got this with
>
> gitk --bisect
>
> while doing some bisection on my current kernel.
>
> It happens with "git rev-parse --bisect" too, but interestingly, "git
> log --bisect" works fine.
>
> I have not tried to figure out anything further, except that it was
> introduced by commit b9c8e7f2f ("prefix_ref_iterator: don't trim too
> much") and it happens with
>
> iter->iter0->refname = "refs/bisect/bad"
> iter->trim = 15
>
> (where 15 is also the same as the length of that refname).
>
> Not having time to chase this down any more, since I'm busy with the
> merge window (and that annoying bisect)What version of git are you running? This should be fixed by 03df567fbf (for_each_bisect_ref(): don't trim refnames, 2017-06-18) which is in v2.14.
More discussion at
https://public-inbox.org/git/cover.1497792827.git.mhagger@alum.mit.edu/
-Peff