Re: [PATCH] repository: fix a sparse 'using integer a NULL pointer' warning

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Aug 22, 2017, 02:11 UTC
Message-ID: <20170822021124.4bmlzpdocgheo55b@genre.crustytoothpaste.net>
In-Reply-To: <91150cfc-3271-16b0-33d3-9a4e149dc9fe@ramsayjones.plus.com>

On Mon, Aug 21, 2017 at 04:48:42PM +0100, Ramsay Jones wrote:

Show 16 quoted lines

> 
> Commit 67a9dfcc00 ("hash-algo: integrate hash algorithm support with
> repo setup", 21-08-2017) added a 'const struct git_hash_algo *hash_algo'
> field to the repository structure, without modifying the initializer
> of the 'the_repo' variable. This does not actually introduce a bug,
> since the '0' initializer for the 'ignore_env:1' bit-field is
> interpreted as a NULL pointer (hence the warning), and the final field
> (now with no initializer) receives a default '0'.
> 
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
> 
> Hi Brian,
> 
> If you need to re-roll your 'bc/hash-algo' branch, could you please
> squash this into the relevant patch.

Of course, thanks. I'll almost certainly be doing a reroll since it's an RFC series and I expect to get more feedback on it.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204