git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH 2/2] submodule: simplify decision tree whether to or not to fetch

From
Heiko Voigt <hvoigt@hvoigt.net>
Date
Aug 18, 2017, 16:06 UTC
Message-ID
<20170818160640.GC69414@book.hvoigt.net>
In-Reply-To
<20170817175007.GA109680@google.com>
On Thu, Aug 17, 2017 at 10:50:07AM -0700, Brandon Williams wrote:
Show 16 quoted lines
> On 08/17, Stefan Beller wrote:
> > On Thu, Aug 17, 2017 at 4:00 AM, Heiko Voigt <hvoigt@hvoigt.net> wrote:
> > > To make extending this logic later easier.
> > >
> > > Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
> > > ---
> > > I am quite sure I replicated the same logic but a few more eyes would be
> > > appreciated.
> > 
> > A code cleanup is appreciated!
> > 
> > I thought Brandon had a series in flight doing a very similar cleanup here,
> > but in master..pu there is nothing to be found.
> 
> Yeah there are 2 series in flight which will probably conflict here.
> bw/grep-recurse-submodules and bw/submodule-config-cleanup

Ok then I will wait until those are in and then see if I can base the cleanup on top. I think it is only necessary as a preparation for the fully fledged fetch configuration logic mess we will get into once we get to the full recursive submodule fetch implementation. Not necessarily needed for the moved submodules.

> > 
> > The code looks good to me.
Thanks.
Cheers Heiko
Previous: Brandon WilliamsNext: Stefan Beller
Message 5 of 11 in “implement fetching of moved submodules”
  1. 1/2 implement fetching of moved submodulesHeiko Voigt, Aug 17, 2017
  2. 2/2 submodule: simplify decision tree whether to or not to fetchHeiko Voigt, Aug 17, 2017
  3. Stefan BellerAug 17, 2017
  4. Brandon WilliamsAug 17, 2017
  5. Heiko VoigtAug 18, 2017
  6. Stefan BellerAug 17, 2017
  7. Heiko VoigtAug 18, 2017
  8. 1/2 implement fetching of moved submodulesHeiko Voigt, Sep 15, 2017
  9. 2/2 submodule: simplify decision tree whether to or not to fetchHeiko Voigt, Sep 15, 2017
  10. Brandon WilliamsSep 18, 2017
  11. Brandon WilliamsSep 18, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.