git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sha1_file: make read_info_alternates static

From
Jeff King <peff@peff.net>
Date
Aug 15, 2017, 21:34 UTC
Message-ID
<20170815213421.amvtzyxfbbajvf4w@sigill.intra.peff.net>
In-Reply-To
<20170815201319.32395-1-sbeller@google.com>
On Tue, Aug 15, 2017 at 01:13:19PM -0700, Stefan Beller wrote:
Show 7 quoted lines
> read_info_alternates is not used from outside, so let's make it static.
> 
> We have to declare the function before link_alt_odb_entry instead of
> moving the code around, link_alt_odb_entry calls read_info_alternates,
> which in turn calls link_alt_odb_entry.
> 
> Signed-off-by: Stefan Beller <sbeller@google.com>

Thanks, this looks good. It should have been part of my series with a5b34d2152 (alternates: provide helper for adding to alternates list, 2016-10-03), which removed the last external call.

-Peff
Previous: Brandon Williams
Message 3 of 3 in “sha1_file: make read_info_alternates static”
  1. sha1_file: make read_info_alternates staticStefan Beller, Aug 15, 2017
  2. Brandon WilliamsAug 15, 2017
  3. Jeff KingAug 15, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.