git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/9] Convert various things to size_t

From
Martin Koegler <martin.koegler@chello.at>
Date
Aug 13, 2017, 17:48 UTC
Message-ID
<20170813174821.GA30330@mail.zuhause>
In-Reply-To
<CAN0heSqu0evvo7dFPwWvgEthoafCVZmJKbRftBbHRhtN_du4HQ@mail.gmail.com>
On Sat, Aug 12, 2017 at 03:27:21PM +0200, Martin Ågren wrote:
Show 27 quoted lines
> On 12 August 2017 at 10:47, Martin Koegler <martin.koegler@chello.at> wrote:
> > From: Martin Koegler <martin.koegler@chello.at>
> >
> > ---
> >  bisect.c                | 2 +-
> >  blame.c                 | 2 +-
> >  builtin/fmt-merge-msg.c | 2 +-
> >  builtin/mktag.c         | 2 +-
> >  dir.c                   | 4 ++--
> >  dir.h                   | 2 +-
> >  6 files changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/bisect.c b/bisect.c
> > index 2549eaf..0580c82 100644
> > --- a/bisect.c
> > +++ b/bisect.c
> > @@ -131,7 +131,7 @@ static void show_list(const char *debug, int counted, int nr,
> >                 struct commit *commit = p->item;
> >                 unsigned flags = commit->object.flags;
> >                 enum object_type type;
> > -               unsigned long size;
> > +               size_t size;
> >                 char *buf = read_sha1_file(commit->object.sha1, &type, &size);
> >                 const char *subject_start;
> >                 int subject_len;
> 
> Would this need to be done in a patch where read_sha1_file is converted?
I missed this first, because it is debug code requiring a code change to be enabled. 
It probably should be merged in my second patch. On the other hand that patch is already considered too large.

Regards, Martin

Previous: Martin ÅgrenNext: Martin Koegler
Message 9 of 27 in “Convert pack-objects to size_t”
  1. 1/9 Convert pack-objects to size_tMartin Koegler, Aug 12, 2017
  2. 4/9 Convert archive functions to size_tMartin Koegler, Aug 12, 2017
  3. 3/9 Convert unpack-objects to size_tMartin Koegler, Aug 12, 2017
  4. Martin ÅgrenAug 12, 2017
  5. Martin KoeglerAug 13, 2017
  6. 8/9 Convert tree-walk to size_tMartin Koegler, Aug 12, 2017
  7. 5/9 Convert various things to size_tMartin Koegler, Aug 12, 2017
  8. Martin ÅgrenAug 12, 2017
  9. Martin KoeglerAug 13, 2017
  10. 7/9 Convert ref-filter to size_tMartin Koegler, Aug 12, 2017
  11. 9/9 Convert xdiff-interface to size_tMartin Koegler, Aug 12, 2017
  12. 6/9 Use size_t for config parsingMartin Koegler, Aug 12, 2017
  13. 2/9 Convert index-pack to size_tMartin Koegler, Aug 12, 2017
  14. Ramsay JonesAug 12, 2017
  15. Torsten BögershausenAug 12, 2017
  16. Martin KoeglerAug 13, 2017
  17. Ramsay JonesAug 12, 2017
  18. Martin KoeglerAug 13, 2017
  19. Ramsay JonesAug 13, 2017
  20. Junio C HamanoAug 13, 2017
  21. Junio C HamanoAug 14, 2017
  22. Ramsay JonesAug 14, 2017
  23. Junio C HamanoAug 14, 2017
  24. Torsten BögershausenAug 14, 2017
  25. Ramsay JonesAug 15, 2017
  26. Martin KoeglerAug 16, 2017
  27. Torsten BögershausenAug 17, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.