Re: [PATCH v2 14/15] unpack-trees: improve loading of .gitmodules

From: Heiko Voigt <hvoigt@hvoigt.net>
Date: Aug 11, 2017, 17:18 UTC
Message-ID: <20170811171811.GC1472@book.hvoigt.net>
In-Reply-To: <20170803182000.179328-15-bmwill@google.com>

On Thu, Aug 03, 2017 at 11:19:59AM -0700, Brandon Williams wrote:

Show 19 quoted lines

> diff --git a/unpack-trees.c b/unpack-trees.c
> index 5dce7ff7d..3c7f464fa 100644
> --- a/unpack-trees.c
> +++ b/unpack-trees.c
> @@ -1,5 +1,6 @@
>  #define NO_THE_INDEX_COMPATIBILITY_MACROS
>  #include "cache.h"
> +#include "repository.h"
>  #include "config.h"
>  #include "dir.h"
>  #include "tree.h"
> @@ -268,22 +269,28 @@ static int check_submodule_move_head(const struct cache_entry *ce,
>  	return 0;
>  }
>  
> -static void reload_gitmodules_file(struct index_state *index,
> -				   struct checkout *state)
> +/*
> + * Preform the loading of the repository's gitmodules file.  This function is

s/Preform/Perform/

and a nit: There is some extra space after the end of this sentence.

Cheers Heiko