git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix delta integer overflows

From
Martin Koegler <martin.koegler@chello.at>
Date
Aug 8, 2017, 06:25 UTC
Message-ID
<20170808062522.GB4091@mail.zuhause>
In-Reply-To
<xmqqvalyn89b.fsf@gitster.mtv.corp.google.com>
On Mon, Aug 07, 2017 at 06:44:16PM -0700, Junio C Hamano wrote:
> Having said that, I am a bit curious how you came to this patch.
> Was the issue found by code inspection, or did you actually have a
> real life use case to raise the core.bigFileThreshold configuration
> to a value above 4GB?
Real life use - tracking changes in larger files.

Raising the limit above 4GB suddenly resulted in a broken pack files in the repository and aborts of various git commands.

Data is still recoverable with all size sanity checks disabled.

Regards, Martin

Previous: Junio C Hamano
Message 11 of 11 in “Fix delta integer overflows”
  1. Fix delta integer overflowsMartin Koegler, Aug 7, 2017
  2. Junio C HamanoAug 7, 2017
  3. Johannes SchindelinAug 7, 2017
  4. Junio C HamanoAug 7, 2017
  5. Johannes SchindelinAug 7, 2017
  6. Junio C HamanoAug 7, 2017
  7. Junio C HamanoAug 7, 2017
  8. Martin KoeglerAug 8, 2017
  9. Johannes SchindelinAug 8, 2017
  10. Junio C HamanoAug 8, 2017
  11. Martin KoeglerAug 8, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.