[PATCH] clone: teach recursive clones to respect -q
- From
- Brandon Williams <bmwill@google.com>
- Date
- Aug 3, 2017, 22:25 UTC
- Message-ID
- <20170803222544.17216-1-bmwill@google.com>
Teach 'git clone --recurse-submodules' to respect the '-q' option by passing down the quiet flag to the process which handles cloning of submodules.
Signed-off-by: Brandon Williams <bmwill@google.com> --- builtin/clone.c | 3 +++ t/t7400-submodule-basic.sh | 6 ++++++ 2 files changed, 9 insertions(+)
diff --git a/builtin/clone.c b/builtin/clone.c index 08b5cc433..f7e17d229 100644 --- a/builtin/clone.c +++ b/builtin/clone.c @@ -768,6 +768,9 @@ static int checkout(int submodule_progress) if (submodule_progress) argv_array_push(&args, "--progress"); + if (option_verbosity < 0) + argv_array_push(&args, "--quiet"); + err = run_command_v_opt(args.argv, RUN_GIT_CMD); argv_array_clear(&args); } diff --git a/t/t7400-submodule-basic.sh b/t/t7400-submodule-basic.sh index dcac364c5..e9c3335b7 100755 --- a/t/t7400-submodule-basic.sh +++ b/t/t7400-submodule-basic.sh @@ -1289,4 +1289,10 @@ test_expect_success 'init properly sets the config' ' test_must_fail git -C multisuper_clone config --get submodule.sub1.active ' +test_expect_success 'recursive clone respects -q' ' + test_when_finished "rm -rf multisuper_clone" && + git clone -q --recurse-submodules multisuper multisuper_clone >actual && + test_must_be_empty actual +' + test_done
-- 2.14.0.rc1.383.gd1ce394fe2-goog