git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fsck: cleanup unused variable

From
Jeff King <peff@peff.net>
Date
Jul 26, 2017, 13:17 UTC
Message-ID
<20170726131729.o6bp2qmlqpl674zt@sigill.intra.peff.net>
In-Reply-To
<20170726013456.4187-1-jonathantanmy@google.com>
On Tue, Jul 25, 2017 at 06:34:56PM -0700, Jonathan Tan wrote:
> Remove the unused variable "heads" from cmd_fsck().
> 
> This variable was made unused in commit c3271a0 ("fsck: do not fallback
> "git fsck <bogus>" to "git fsck"", 2017-01-17).
Thanks, I should have caught this then.

The patch is obviously correct, though I'm curious why gcc's -Wunused-but-set-variable didn't catch this.

-Peff
Previous: Jonathan Tan
Message 2 of 2 in “fsck: cleanup unused variable”
  1. fsck: cleanup unused variableJonathan Tan, Jul 26, 2017
  2. Jeff KingJul 26, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.