Re: [PATCH] dir: support platforms that require aligned reads
- From
Jeff King <peff@peff.net>
- Date
- Jul 16, 2017, 16:03 UTC
- Message-ID
- <20170716160313.2crnw6exyqpvp7ue@sigill.intra.peff.net>
- In-Reply-To
- <84b4d5aa-956f-932b-4e95-f181243215bc@web.de>
On Sun, Jul 16, 2017 at 05:18:27PM +0200, René Scharfe wrote:
Show 9 quoted lines
> > it looks like assumptions about struct layout are pervasive and part of > > the on-disk format. Yuck. :( > > Assuming that there is no padding probably even works for the platforms > the code currently supports (basically x86), but I don't know about > others. We'd need to change the writing side as well to match, though. > Which is probably a good idea, but I tried to keep the patch small and > its impact low. Cross-machine usability is currently explicitly not > supported -- not sure why, though.
Yeah, I think your patch is a good first step, and we don't have to go further for now.
-Peff