git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] ls-files: don't try to prune an empty index

From
Jeff King <peff@peff.net>
Date
Jul 16, 2017, 11:08 UTC
Message-ID
<20170716110831.c442ihan6tzf7gmn@sigill.intra.peff.net>
In-Reply-To
<e91c204d-0bcb-9614-b62d-cd87c03b92e1@web.de>
On Sun, Jul 16, 2017 at 01:06:45PM +0200, René Scharfe wrote:
Show 20 quoted lines
> > > diff --git a/builtin/ls-files.c b/builtin/ls-files.c
> > > index b8514a0029..adf572da68 100644
> > > --- a/builtin/ls-files.c
> > > +++ b/builtin/ls-files.c
> > > @@ -362,7 +362,7 @@ static void prune_index(struct index_state *istate,
> > >   	int pos;
> > >   	unsigned int first, last;
> > > 
> > > -	if (!prefix)
> > > +	if (!prefix || !istate->cache_nr)
> > >   		return;
> > >   	pos = index_name_pos(istate, prefix, prefixlen);
> > >   	if (pos < 0)
> > 
> > "git am" complained that this does not apply to its blobs. Did you
> > hand-edit?
> 
> I didn't, but perhaps I messed up the order of patches?  MOVE_ARRAY
> patch 2 touches the same file, but I wouldn't expect the two changes to
> conflict.  So not sure what's going on.

For some reason there's an extra space before the tab on each of the context lines. MUA issue or cut-and-paste, maybe?

-Peff
Previous: René ScharfeNext: René Scharfe
Message 6 of 9 in “ls-files: don't try to prune an empty index”
  1. ls-files: don't try to prune an empty indexRené Scharfe, Jul 15, 2017
  2. Ramsay JonesJul 16, 2017
  3. René ScharfeJul 16, 2017
  4. Jeff KingJul 16, 2017
  5. René ScharfeJul 16, 2017
  6. Jeff KingJul 16, 2017
  7. René ScharfeJul 16, 2017
  8. René ScharfeJul 16, 2017
  9. ls-files: don't try to prune an empty indexRené Scharfe, Jul 16, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.