Re: [PATCH 2/1] bswap: convert get_be16, get_be32 and put_be32 to inline functions

From: Jeff King <peff@peff.net>
Date: Jul 16, 2017, 10:28 UTC
Message-ID: <20170716102815.gl24fbfzlom2ena3@sigill.intra.peff.net>
In-Reply-To: <20170716102704.2yywbidmmjv7zfxh@sigill.intra.peff.net>

On Sun, Jul 16, 2017 at 06:27:04AM -0400, Jeff King wrote:

Show 15 quoted lines

> On Sat, Jul 15, 2017 at 09:22:50PM +0200, René Scharfe wrote:
> 
> > Simplify the implementation and allow callers to use expressions with
> > side-effects by turning the macros get_be16, get_be32 and put_be32 into
> > inline functions.
> > 
> > Signed-off-by: Rene Scharfe <l.s.r@web.de>
> > ---
> > All these redundant casts started to bother me, so I tried to come up
> > with nice and clean inline functions.  Successfully?  You tell me.
> > They are longer, but less cluttered.  Would it punish -O0 builds?  Is
> > it all worth it?
> 
> I do think the end result is a lot more readable. On gcc 6 at least, the
> function seems[1] to end up inlined even with -O0.

For my footnote. I was just going to show the test file I compiled:

  #include "git-compat-util.h"
  uint32_t foo(const char *x)
  {
	return get_be32(x);
  }

It's possible the optimizer may behave differently on a more complicated input, but it does show that -O0 is still willing to inline.

-Peff