Re: git config --help not functional on bad config

From: Jeff King <peff@peff.net>
Date: Jul 11, 2017, 19:19 UTC
Message-ID: <20170711191913.jjvw6kqtywyeyf7a@sigill.intra.peff.net>
In-Reply-To: <CAGZ79kbL=Ry_6L9iJw1GQA39gdPsS=twoJFpKPc3ZP+M2saoWA@mail.gmail.com>

On Tue, Jul 11, 2017 at 12:13:59PM -0700, Stefan Beller wrote:

Show 14 quoted lines

> > There are other die calls hidden deeper. For instance:
> >
> >   $ git -c core.ignorecase=foo help config
> >   fatal: bad numeric config value 'foo' for 'core.ignorecase': invalid unit
> >
> > Those ones are hard to fix without changing the call signature of
> > git_config_bool().
> 
> Good point. While looking at it, parse_help_format can also die,
> so building a safe git help config is hard:
> 
>     git config --global help.format foo
>     # everything is broken, how do I fix it?
>     git help config # breaks, too, for the same reason as you outlined :/

Yeah, I think that should be switched to return an error, and probably all errors from git_help_config() should issue a warning and still return 0.

-Peff