git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v9 4/7] convert: put the flags field before the flag itself for consistent style

From
Lars Schneider <larsxschneider@gmail.com>
Date
Jun 30, 2017, 20:41 UTC
Message-ID
<20170630204128.48708-5-larsxschneider@gmail.com>
In-Reply-To
<20170630204128.48708-1-larsxschneider@gmail.com>
Suggested-by: Jeff King <peff@peff.net>
Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
---
 convert.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/convert.c b/convert.c
index f1e168bc30..9907e3b9ba 100644
--- a/convert.c
+++ b/convert.c
@@ -597,12 +597,12 @@ static int apply_multi_file_filter(const char *path, const char *src, size_t len
 	}
 	process = &entry->subprocess.process;
 
-	if (!(wanted_capability & entry->supported_capabilities))
+	if (!(entry->supported_capabilities & wanted_capability))
 		return 0;
 
-	if (CAP_CLEAN & wanted_capability)
+	if (wanted_capability & CAP_CLEAN)
 		filter_type = "clean";
-	else if (CAP_SMUDGE & wanted_capability)
+	else if (wanted_capability & CAP_SMUDGE)
 		filter_type = "smudge";
 	else
 		die("unexpected filter type");
@@ -703,9 +703,9 @@ static int apply_filter(const char *path, const char *src, size_t len,
 	if (!dst)
 		return 1;
 
-	if ((CAP_CLEAN & wanted_capability) && !drv->process && drv->clean)
+	if ((wanted_capability & CAP_CLEAN) && !drv->process && drv->clean)
 		cmd = drv->clean;
-	else if ((CAP_SMUDGE & wanted_capability) && !drv->process && drv->smudge)
+	else if ((wanted_capability & CAP_SMUDGE) && !drv->process && drv->smudge)
 		cmd = drv->smudge;
 
 	if (cmd && *cmd)
-- 
2.13.2
Previous: Lars SchneiderNext: Lars Schneider
Message 5 of 9 in “convert: add "status=delayed" to filter process protocol”
  1. 0/7 convert: add "status=delayed" to filter process protocolLars Schneider, Jun 30, 2017
  2. 1/7 t0021: keep filter log files on comparisonLars Schneider, Jun 30, 2017
  3. 3/7 t0021: write "OUT <size>" only on successLars Schneider, Jun 30, 2017
  4. 5/7 convert: move multiple file filter error handling to separate functionLars Schneider, Jun 30, 2017
  5. 4/7 convert: put the flags field before the flag itself for consistent styleLars Schneider, Jun 30, 2017
  6. 7/7 convert: add "status=delayed" to filter process protocolLars Schneider, Jun 30, 2017
  7. 6/7 convert: refactor capabilities negotiationLars Schneider, Jun 30, 2017
  8. 2/7 t0021: make debug log file name configurableLars Schneider, Jun 30, 2017
  9. Junio C HamanoJun 30, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.