Re: [PATCH] pack-bitmap: Don't perform unaligned memory access

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jun 27, 2017, 00:06 UTC
Message-ID: <20170627000600.GD161648@aiede.mtv.corp.google.com>
In-Reply-To: <20170626151612.64019-1-jrtc27@jrtc27.com>

James Clarke wrote:

Show 9 quoted lines

> The preceding bitmap entries have a 1-byte XOR-offset and 1-byte flags,
> so their size is not a multiple of 4. Thus the name-hash cache is only
> guaranteed to be 2-byte aligned and so we must use get_be32 rather than
> indexing the array directly.
>
> Signed-off-by: James Clarke <jrtc27@jrtc27.com>
> ---
>  pack-bitmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Failing build log: https://buildd.debian.org/status/fetch.php?pkg=git&arch=sparc64&ver=1%3A2.13.2-2&stamp=1498520310&raw=0

Thanks for tracking down and fixing it.