git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] mergetools/meld: improve backwards-compatibiilty when using "--output"

From
David Aguilar <davvid@gmail.com>
Date
Jun 19, 2017, 00:20 UTC
Message-ID
<20170619002027.27346-1-davvid@gmail.com>

Meld 3.16.0 requires a "=" in the --output argument, as it uses a simple hand-rolled command-line parser.

Newer versions of Meld (3.16.4, and possibly earlier) use optparse, which accepts either "--output <file>" or "--output=<file>".

Use "--output=<file>" for better compatibility.
Signed-off-by: David Aguilar <davvid@gmail.com>
---
Changes since v1:

Fixed an "optpaarse" -> "optparse" typo in the commit message. This patch is otherwise identical to v1.

 mergetools/meld | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mergetools/meld b/mergetools/meld
index bc178e8882..7a08470f88 100644
--- a/mergetools/meld
+++ b/mergetools/meld
@@ -10,7 +10,7 @@ merge_cmd () {
 
 	if test "$meld_has_output_option" = true
 	then
-		"$merge_tool_path" --output "$MERGED" \
+		"$merge_tool_path" --output="$MERGED" \
 			"$LOCAL" "$BASE" "$REMOTE"
 	else
 		"$merge_tool_path" "$LOCAL" "$MERGED" "$REMOTE"
-- 
2.13.1.453.gc0395165f3
Message 1 of 1 in “mergetools/meld: improve backwards-compatibiilty when using "--output"”
  1. mergetools/meld: improve backwards-compatibiilty when using "--output"David Aguilar, Jun 19, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.